sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Missing layoutSubviews spans for non animating viewControllers transaction

Open brustolin opened this issue 3 years ago • 5 comments

When a new viewController is presented without animation the ui life cycle changes. With animation, the last method to be called is viewDidAppear, and we finish the transaction in this one. Without animation, methods related to layout subviews are called after viewDidAppear, and we don't measure them. Depending on the the amount of subviews, those methods can take a while, and thats why is important to measure them.

brustolin avatar Dec 02 '21 13:12 brustolin

We could solve this with waitWithTimeout similar as we have it on Flutter and JavaScript. Maybe we can also detect in the run loop or through screen rendering when the UIViewController finishes.

philipphofmann avatar Dec 22 '21 14:12 philipphofmann

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jan 12 '22 15:01 github-actions[bot]

I believe this need to be on backlog.

brustolin avatar Jan 12 '22 16:01 brustolin

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Feb 04 '22 15:02 github-actions[bot]

Is this still an issue @brustolin?

philipphofmann avatar Feb 28 '24 13:02 philipphofmann