sentry-cli icon indicating copy to clipboard operation
sentry-cli copied to clipboard

Fall back to co-location heuristic if sourcemap url appears remote

Open brettdh opened this issue 2 years ago • 4 comments

Applies a heuristic to guess that a sourcemap URL is a remote URL path (without scheme and domain):

  1. The string starts with /
  2. The string is not a path to an existing local file

Fixes #1870.

brettdh avatar Dec 21 '23 15:12 brettdh

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jan 30 '24 00:01 github-actions[bot]

This is still on my todo list.

brettdh avatar Jan 30 '24 01:01 brettdh

...but the stalebot did not remove the label. 🤔

brettdh avatar Jan 30 '24 18:01 brettdh

...but the stalebot did not remove the label. 🤔

I removed "Status: Stale" and added "Status: In Progress." Hopefully StaleBot leaves the PR alone going forward

szokeasaurusrex avatar Jan 31 '24 10:01 szokeasaurusrex

@brettdh is this still in progress?

szokeasaurusrex avatar Jul 17 '24 15:07 szokeasaurusrex

Hmm, I thought I'd responded to these changes already, sorry. I'll try to push an update today.

brettdh avatar Jul 17 '24 16:07 brettdh

Responded to the comments above and resolved one. Please let me know if more is required.

brettdh avatar Jul 17 '24 16:07 brettdh