sentry-cli
sentry-cli copied to clipboard
`sourcemaps inject` should fall back to co-located source maps if exact path can't be found
Environment
What version of the CLI and what OS are you running?
Sentry CLI 1.23.0, macOS Ventura 13.4
Steps to Reproduce
Similar to #1846:
- Create a
.js
file with a corresponding.js.map
file in the same directory - Add a source map comment pointing to a path that doesn't exist locally; e.g.
Note: this is a mostly-real example from a starter Remix app. The path here is the default when creating a new app from the grunge stack, but this issue will occur for any static assets path, whether or not it has a URL scheme and domain.//# sourceMappingURL=/_static/build/foo.js.map
- Run
sentry-cli sourcemaps inject foo.js*
Alternatively, though it was created to repro a different bug, you can also repro this bug by following the steps here, ignoring the AWS bits and running npm run build
instead of any of the other scripts. The sentry-cli sourcemaps inject
step will show missing debug IDs for the sourcemap files.
Expected Result
JS file and sourcemap file both have debug ID injected
Actual Result
Only JS file has debug ID injected
Logs
When filing a bug report, please attach debug logs, either by using --log-level=debug
flag or SENTRY_LOG_LEVEL=debug
environment variable.
@brettdh thanks for opening this issue. Might take a while for us to look at it with the holidays coming up.
Should have mentioned - I'm working on a PR already, as it's a trivial addition to my last one.
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog
or Status: In Progress
, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
Sorry, I've let the PR here become idle. I'll try to get back to it soon.
I put a "Status: Backlog" label on this PR so StaleBot keeps it open