sentry-cli icon indicating copy to clipboard operation
sentry-cli copied to clipboard

fix: Set bash as the interpretter for bash-hook command

Open kamilogorek opened this issue 2 years ago • 3 comments

Shell script produced by bash-hook was missing a shebang, which caused it to be executed by sh in some environments. And because sh has no process substitution (https://www.shellcheck.net/wiki/SC3001) it failed with a syntax error.

Fixes https://github.com/getsentry/sentry-cli/issues/1260

kamilogorek avatar Jun 27 '22 13:06 kamilogorek

@mitsuhiko not sure what's reliable way of detecting used interpreter

kamilogorek avatar Jun 27 '22 13:06 kamilogorek

How would $SHELL tell you that you are not using sh? 🤔

kamilogorek avatar Jul 05 '22 14:07 kamilogorek

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jul 27 '22 00:07 github-actions[bot]

This wont work, so cleaning it up for now.

kamilogorek avatar Dec 06 '22 13:12 kamilogorek