sentry-capacitor
sentry-capacitor copied to clipboard
getsentry
fix: remove unnecessary dependencies to promises and @sentry/wizard
Sentry/capacitor had a runtime dependency on Sentry/wizard, which then depends on rxjs through inquirer.
This cause issues in monorepo configurations, for instance : https://github.com/ReactiveX/rxjs/issues/6628 and https://github.com/webpack/webpack/issues/14405.
Since Sentry/wizard is more or less a CLI tool, it is not required as a runtime dependency.
wizard may be required once https://github.com/getsentry/sentry-capacitor/issues/39 is implemented.
wizard may be required once #39 is implemented.
That also sounds like a dev dependency. I believe the OP's point still stands.
That said I recall we removed it once on React Native, and it caused issue.
https://github.com/getsentry/sentry-react-native/pull/2015
The PR linked doesn't say what error it was throwing, so it's unclear to me if this would break things here too. Maybe @jennmueng (author of the PR) or @marandaneto (approver) have additional thoughts
@bruno-garcia The issue with https://github.com/getsentry/sentry-react-native/pull/2015 was that the linking script for RN on iOS automatically runs the Sentry Wizard, which wouldn't exist and would fail.
As we don't do any auto linking scripts here AFAIK that use the wizard we should be good to remove it.
Hello, is there a way to hack this up with patch-package so we don't ship @sentry/wizard with our .... webapp?
Yes it's true, this react-native module affect our web bundle , see https://github.com/getsentry/sentry-react-native/issues/2409
An update: Sentry Wizard will be supported by Capacitor, the promises package will be removed from the dependencies and Sentry Wizard will be moved to the devDependencies. All that after the integration with the Wizard is completed
This pull request has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
An update: Sentry Wizard will be supported by Capacitor, the promises package will be removed from the dependencies and Sentry Wizard will be moved to the devDependencies. All that after the integration with the Wizard is completed
Should we reopen this issue? The stale bot closed it.
Hello! What's the status of this issue? npm audit --omit=dev throws 3 critical vulnerabilities because of that dependencies.
wizard may be required once #39 is implemented.
I don't think we should keep things "for the future". Moreover, we can always restore dependencies from the git history
PS: I can create new PR if needed
This PR will move to https://github.com/getsentry/sentry-capacitor/pull/400 Thank you @olivier-blanc-openit for the contribution!