sentry-auth-google icon indicating copy to clipboard operation
sentry-auth-google copied to clipboard
verified publisher icon getsentry

Allow configuration from environment variables

Open ianyamey opened this issue 9 years ago • 3 comments

Allows configuration of the GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET using Environment Variables

This change is Reviewable

ianyamey avatar Aug 31 '16 16:08 ianyamey

I'd rather this be supported via sentry.options. Environment variables are problematic for various reasons, and we're never going to support "configure everything with env vars".

dcramer avatar Aug 31 '16 16:08 dcramer

@dcramer, no problem. Can you point me to an example of sentry.options or elaborate on your suggested approach?

ianyamey avatar Sep 01 '16 13:09 ianyamey

Best bet is to look in sentrys code on GitHub. src/sentry/options. Specifically you need .register and .get.  We also don't have a way to expose these via web UI yet but they could still be set with CLI. 

On Thu, Sep 1, 2016 at 6:38 AM -0700, "Ian Yamey" [email protected] wrote:

@dcramer, no problem. Can you point me to an example of sentry.options or elaborate on your suggested approach?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

dcramer avatar Sep 01 '16 16:09 dcramer