sentry-auth-github icon indicating copy to clipboard operation
sentry-auth-github copied to clipboard

Update instruction in the README

Open tino opened this issue 8 years ago • 3 comments

I was thrown off by instructions from an earlier version that talked about /account/settings/social/associate/complete/github/, and the current wording didn't make clear to me that this has changed. Hopefully this does to others :)

Also add a line about GITHUB_ORGANIZATION

tino avatar Apr 23 '17 13:04 tino

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #17   +/-   ##
====================================
  Coverage      49%   49%           
====================================
  Files           9     9           
  Lines         200   200           
====================================
  Hits           98    98           
  Misses        102   102

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 397a658...7d62aec. Read the comment docs.

codecov-io avatar Apr 23 '17 13:04 codecov-io

I'm not sure how this is really any different. Appears to me its just adding "for example", and makes the formatting less structured around it.

dcramer avatar Apr 23 '17 17:04 dcramer

It changes the wording from "use the field as the sentry setting" to "use the sentry setting as the field value", which makes quite a lot of difference :)

tino avatar Apr 25 '17 12:04 tino