sentry-android icon indicating copy to clipboard operation
sentry-android copied to clipboard

draft about distinct id implementation

Open marandaneto opened this issue 5 years ago • 1 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [ ] New feature
  • [X] Enhancement
  • [ ] Refactoring

:scroll: Description

draft about distinct id implementation

:bulb: Motivation and Context

distinctId should be changeable, but still keeping compatibility with older SDKs. secureAndroidId should be deprecated, but still possible to keep compatibility.

:green_heart: How did you test it?

no tests at all, only a draft PR to support my DACI request.

:pencil: Checklist

  • [ ] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] All tests passing

:crystal_ball: Next steps

get approval and do the real implementation.

marandaneto avatar Apr 06 '20 15:04 marandaneto

I added a few comments :)

thanks for the review :) just emphasizing that this Draft PR is only to support the DACI, not a final implementation. I've replied all of them o/

marandaneto avatar Apr 07 '20 17:04 marandaneto