sentry-android-gradle-plugin icon indicating copy to clipboard operation
sentry-android-gradle-plugin copied to clipboard

Fix circular depencency issue between mergeAssets and minify tasks

Open markushi opened this issue 1 year ago • 0 comments

:scroll: Description

Fixes https://github.com/getsentry/sentry-react-native/issues/3644

The task tree for a simple flutter app, without our sentry plugin being applied looks like this: compileReleaseKotlin->processReleaseResources->copyFlutterAssetsRelease->mergeReleaseAssets

Right now our generateDebugMetaProperties depends on both mergeReleaseAssets and packageRelease, creating a circular dependency.

AGP < 7.4: Removing the mergeAssets tasks dependency seems to be fine as the task tree is still executed correctly, and the debug meta file is still present in the final APK.

AGP >= 7.4: Utilize a merge assets transformer to inject our properties file.

:green_heart: How did you test it?

Updated tests.

:pencil: Checklist

  • [ ] I reviewed the submitted code
  • [ ] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [ ] No breaking changes

:crystal_ball: Next steps

Look into AGP > 7.4.0

markushi avatar Mar 27 '24 10:03 markushi