sentry-android-gradle-plugin icon indicating copy to clipboard operation
sentry-android-gradle-plugin copied to clipboard

Add app context to ProGuard mappings uploaded.

Open bruno-garcia opened this issue 4 years ago • 1 comments

Pass additional information to sentry-cli to augment what we know about the mappings.txt we're uploading. The goal is to surface more information in the ProGuard page in Sentry Settings.

Data to pass to sentry-cli, app's:

  • name
  • id
  • version

See also: https://github.com/getsentry/sentry-java/issues/954

sentry-cli already accepts some extra fields: https://github.com/getsentry/sentry-cli/blob/master/src/commands/upload_proguard.rs#L41-L72

But we might need to extend it, and add support on the server. Needs discussion.

bruno-garcia avatar Feb 08 '21 16:02 bruno-garcia

turns out that https://github.com/getsentry/sentry-cli/blob/master/src/commands/upload_proguard.rs#L41-L72 is dead code so sentry-cli needs to support such new properties and Sentry UI should offer a way to display and filter such new properties

marandaneto avatar May 31 '21 07:05 marandaneto

Regarding the data fields, I guess it makes most sense to map the props the following way:

name: build.gradle -> applicationId id: build.gradle -> versionCode version: build.gradle -> versionName

markushi avatar Apr 03 '23 12:04 markushi

@jan-auer it looks like we had a similar feature in the distant past: https://github.com/getsentry/sentry/pull/10246 Any chance you remember why it was removed?

markushi avatar Apr 03 '23 13:04 markushi