sentry-android-gradle-plugin icon indicating copy to clipboard operation
sentry-android-gradle-plugin copied to clipboard

AbstractInstallStrategy should warn the user about a new sentry-something version installed

Open romtsn opened this issue 3 years ago • 4 comments

Description

This strategy could issue a warning if it counts more than one occurence of the sentry-android-core/sentry-android-okhttp/etc module in the dependency tree, which could happen in case if it comes as a transitive dependency AND our auto-installation kicks in.

We could warn a user that we've upgraded his sentry-android-something version to the latest and advice him to explicitly specify it via configuration sentryVersion. We only do this for the upgrade (so if they have a higher transitive version, that's probably what they want anyway and we don't warn)

romtsn avatar Jun 09 '22 14:06 romtsn

Shouldn't this be the build system's job that resolves the dependencies?

philipphofmann avatar Jun 29 '22 12:06 philipphofmann

what do you mean by "this" exactly? Warning the user? It won't do it, it will just resolve it to the latest, but we could notify the user that we auto-installed a higher version of the sdk, so they are aware of potential issues and it's not a silent update.

romtsn avatar Jun 29 '22 12:06 romtsn

Yes, that's the expected behavior of the build system. So you want to print a warning to be nice to inform the user in case he is not aware of that expected behavior?

philipphofmann avatar Jun 29 '22 14:06 philipphofmann

no, we want to print a warning to inform the user that we auto-installed a new mismatching version of the sentry sdk, because the auto-installation feature is on by default, and they might not be aware of it.

romtsn avatar Jun 29 '22 14:06 romtsn