self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

Update provider_name on custom SAML2 Provider login page

Open chriscupas opened this issue 3 years ago • 9 comments

Problem Statement

In getsentry/sentry code base, Is there a way to change the login button label for custom SAML2 ? For now I can only see that it is being returned as object in auth_provider file

organization-login.html <span class="provider-logo {{ provider_key }}"></span> Login with {{ provider_name }}

auth_provider.py

return {
            "id": str(obj.id),
            "provider_name": obj.provider,
            "pending_links_count": pending_links_count,
            "login_url": absolute_uri(login_url),
            "default_role": organization.default_role,
            "require_link": not obj.flags.allow_unlinked,
            "scim_enabled": bool(obj.flags.scim_enabled),
        }

This would only mean that it is being fetched from the source getsentry/self-hosted DB

Solution Brainstorm

It would be great if we can just specify in config of getsentry/self-hosted something like

provider.name: "Esttablishment name"

chriscupas avatar Jun 06 '22 11:06 chriscupas

You could probably set it manually in your database, right? Did you try that?

chadwhitacre avatar Jun 22 '22 19:06 chadwhitacre

You could probably set it manually in your database, right? Did you try that?

I did tried to update the sentry_authprovider table matching saml2 but it is causing error or am I updating the wrong one ?

chriscupas avatar Jun 23 '22 07:06 chriscupas

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jul 15 '22 00:07 github-actions[bot]

Did you have any luck with this @chriscupas?

chadwhitacre avatar Jul 15 '22 22:07 chadwhitacre

Did you have any luck with this @chriscupas?

@chadwhitacre not yet ... I am thinking of updating the core https://github.com/getsentry/sentry that can accept options, but don't know where to start.

chriscupas avatar Jul 16 '22 06:07 chriscupas

Any pointers here, @getsentry/enterprise?

chadwhitacre avatar Jul 18 '22 19:07 chadwhitacre

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Aug 10 '22 00:08 github-actions[bot]

Will be looking to work on this next week and see what I can do ... but initial plan will still be the same for updating the core. @chadwhitacre I will be happy for any input from you. Thank you. :)

chriscupas avatar Aug 10 '22 07:08 chriscupas

Ooh, nice! Can you paste a screenshot for me of where this would change so I can wrap my head around the ask here?

chadwhitacre avatar Aug 15 '22 16:08 chadwhitacre

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Aug 10 '23 07:08 getsantry[bot]