self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

GitHub OAuth token must be able to be passed through environment variables not configs

Open inductor opened this issue 2 years ago • 3 comments

Problem Statement

In documentation it is written that you need to pass the following parameters by yaml file.

github-app.id: <App ID>
github-app.name: '<GitHub App name>'
github-app.webhook-secret: '<Webhook secret>' # Use only if configured in GitHub
github-app.client-id: '<Client ID>'
github-app.client-secret: '<Client secret>'
github-app.private-key: |
  -----BEGIN RSA PRIVATE KEY-----
  privatekeyprivatekeyprivatekeyprivatekey
  privatekeyprivatekeyprivatekeyprivatekey
  privatekeyprivatekeyprivatekeyprivatekey
  privatekeyprivatekeyprivatekeyprivatekey
  privatekeyprivatekeyprivatekeyprivatekey
  -----END RSA PRIVATE KEY-----

This is not ideal where you want to automate provisions especially on cloud or kubernetes. Is it possible to provide a way to pass those variables from environment variables not config.yaml?

Solution Brainstorm

No response

inductor avatar Jun 03 '22 01:06 inductor

What do other people do here? Presumably you're not the only one with this pain point. My hunch is people are auto-generating the yml file but I'm not sure.

chadwhitacre avatar Jun 03 '22 13:06 chadwhitacre

Auto-generation does not solve this problem from the product side and my opinion is that this should be solved by the product because it's absolutely based on a bad design.

inductor avatar Jun 03 '22 22:06 inductor

I haven't revisited our configuration story in a while but I'm sure it could use a cleanup. Putting this on the backlog for now.

chadwhitacre avatar Jun 22 '22 19:06 chadwhitacre