Cleanup ClientReport conversion in Relay

[Dav1dde]

The following code was added to outcomes:

            Outcome::Invalid(DiscardReason::InvalidSignature | DiscardReason::MissingSignature) => {
                &mut client_report.discarded_events
            }

To convert certain outcomes to discarded events, presumably just for testing.

We should probably not special case some outcomes here and prefer doing it for everything or nothing.
Do we even need this, presumably this was just added for tests, where tests can be configured for a different transport of outcomes and it should work just fine.

If there is a different desire of managed/customer Relays to transport invalid outcomes we should find a better solution for that.

[linear[bot]]

RELAY-139 Cleanup ClientReport conversion in Relay