relay icon indicating copy to clipboard operation
relay copied to clipboard

Add EAP attribute and size limits

Open Dav1dde opened this issue 6 months ago • 2 comments

We want to enable a trimming processor both for spans and logs which truncates attributes based on count and/or size.

Spans should not exceed ~1MiB and there was a discussion of limiting to around 1000 attributes, but we can still iterate on this, the important part is the trimming processor works for spans.

We'll also have to decide whether we want truncated attributes or not, I think currently we're leaning towards trimmed/partial attributes.

Dav1dde avatar Jun 12 '25 15:06 Dav1dde

Hi team, posted https://github.com/getsentry/sentry-javascript/issues/17345. Some thoughts what would be most helpful:

  • Including the compiled code is almost certainly useless for most users and just wasting resources.
  • Using the wasm magic bytes and converting them to a descriptive span attribute would be helpful though, ie label it as wasm based on magic bytes, extract version from them, and maybe some other other metadata like blob size and first n chars. Something like '[WASM blob: ' + sizeKB + 'KB, hash:' + hash + ... ']';
  • Use above as description, then url and http.url could be a simple wasm blob or generic base64 blob.

Thanks for tackling!

brunohaid avatar Aug 08 '25 14:08 brunohaid

I talked with @Lms24 again about your exact issue, he'll investigate again specifically for your case where data urls/blobs are added to the payloads, as you say, they are not useful. And I'd argue in this case it's not a matter of too long data, but valid/useless data.

In general we will employ some trimming, ideally trimming out the least useful data first.

Dav1dde avatar Aug 11 '25 15:08 Dav1dde