relay icon indicating copy to clipboard operation
relay copied to clipboard

Allow to configure arbitrary headers passed in http calls.

Open dmajere opened this issue 7 months ago • 5 comments

For sentry.io production infrastructure we plan to have some envoy route matching based on additional header. Allow to configure arbitrary headers passed to upstreams.

dmajere avatar May 08 '25 00:05 dmajere

Used host_header as example, added https://github.com/getsentry/relay/pull/4713

dmajere avatar May 08 '25 05:05 dmajere

@dmajere Can envoy not just itself add that header? Istio can do it, so why do we need that in the application?

Dav1dde avatar May 08 '25 07:05 Dav1dde

No, this header is used by envoy to pick correct upstream.

dmajere avatar May 08 '25 16:05 dmajere

I don't understand this use case, if you want a host header, you should just configure the upstream URL correctly, especially the host header is the header which is controlled by the HTTP client framework, messing with that is not a good idea.

Dav1dde avatar May 08 '25 19:05 Dav1dde

Here is the full explanation of a problem and solution we aim to https://www.notion.so/sentry/US-Frontend-routing-1eb8b10e4b5d808fb561f335c15ad423?pvs=4

dmajere avatar May 09 '25 16:05 dmajere

Gonna close this for now as this seems to have stalled: https://github.com/getsentry/relay/pull/4713#issuecomment-2901146307

Dav1dde avatar Jul 02 '25 12:07 Dav1dde