Form Data events are dropped

[Dav1dde]

Form Data events are dropped in the store.

https://github.com/getsentry/relay/blob/3bd026610b483e3c1120238b7e1aa5dd0feecc4d/relay-server/src/services/store.rs#L283-L302

S4S Issue

[jjbayer]

I added some more metadata to the error, but I don't see a pattern. We might need to attach the entire incoming envelope to the error to see if this is a bug or just custom SDK setups sending invalid envelopes.

[Dav1dde]

Option: Just drop it in the store.

[iambriccardo]

This test replicates the error:

def test_attachments_with_form_data(
    mini_sentry, relay_with_processing, attachments_consumer, outcomes_consumer
):
    project_id = 42
    event_id = "515539018c9b4260a6f999572f1661ee"

    mini_sentry.add_full_project_config(project_id)
    relay = relay_with_processing()
    attachments_consumer = attachments_consumer()
    outcomes_consumer = outcomes_consumer()

    # Create attachments with both file content and form data
    attachments = [
        ("att_1", "foo.txt", b"file content"),
        ("form_key", None, b"form value")  # Form data entry
    ]

    relay.send_attachments(project_id, event_id, attachments)

[iambriccardo]

The problem was found, we are discussing offline what is the expected handling of form data. If it should be converted into its own event or produced as attachment.