relay icon indicating copy to clipboard operation
relay copied to clipboard

OS `raw_description` does not get parsed: Windows 10

Open bruno-garcia opened this issue 3 years ago • 7 comments

On a Unity WebGL we send os.raw_description as WIndows 10 but it doesn't get parsed.

image

    "os": {
      "raw_description": "Windows 10",
      "type": "os"
    },

Might require changes in the os regex's: https://github.com/getsentry/relay/blob/f17b293c83ae1344e046760656ca2bb8f201b4b8/relay-general/src/store/normalize/contexts.rs#L8-L9

Relates to: https://github.com/getsentry/relay/issues/1171

JSON: missing_os_windows_10.json.zip

bruno-garcia avatar May 09 '22 19:05 bruno-garcia

Do we generally want to support any string provided by https://docs.unity3d.com/ScriptReference/SystemInfo-operatingSystem.html?

jjbayer avatar May 10 '22 07:05 jjbayer

Do we generally want to support any string provided by docs.unity3d.com/ScriptReference/SystemInfo-operatingSystem.html?

I believe that's in there in PRs (maybe #1088 #1201) I believe @RaduW knows details.

In this case it's a WebGL build, so it's actually running on the browser. We might support that today from parsing User-Agent because it works for the JavaScript SDK. But here we're sending this value in the os.raw_description same as we send any other Unity event (not running on the browser).

bruno-garcia avatar May 10 '22 23:05 bruno-garcia

@bruno-garcia Do you know what we send in os.raw_description for WebGL builds on other operating systems? The reason I'm asking is that I'd rather update the regex for an exhaustive list of values than for this single instance of "Windows 10".

jjbayer avatar May 11 '22 08:05 jjbayer

@bruno-garcia Do you know what we send in os.raw_description for WebGL builds on other operating systems? The reason I'm asking is that I'd rather update the regex for an exhaustive list of values than for this single instance of "Windows 10".

@bitsandfoxes @vaind have you seen the values coming from Mobile and Desktop versions?

bruno-garcia avatar May 13 '22 18:05 bruno-garcia

I haven't run it elsewhere but I will give it a go.

vaind avatar May 13 '22 18:05 vaind

  • macOS - MacOS 10.15.7 - works fine
  • iOS - iPhoneOS 14.5 - kinda works but the icon isn't right in the header - not sure that's related image
  • Android - Android 12 - parsing doesn't work
  • Windows - Windows 10 - parsing doesn't work
  • Linux - Ubuntu 20.04 on HyperV - Unknown OS Unknown OS Version - not helpful

vaind avatar May 30 '22 14:05 vaind

iPhoneOS 14.5

@jjbayer this one we should normalize to "iOS".

jan-auer avatar May 31 '22 08:05 jan-auer