raven-python icon indicating copy to clipboard operation
raven-python copied to clipboard

Do not record errors for terminals

Open mitsuhiko opened this issue 8 years ago • 5 comments

This will not record errors by default if a tty is detected. If you want to record anyways do not register the default hook and manually install it with the flag flipped.

mitsuhiko avatar Dec 05 '16 17:12 mitsuhiko

offline conversation around this was how noisy things like custom scripts are when you're fucking around from a terminal

+1

dcramer avatar Dec 05 '16 17:12 dcramer

@dcramer added test

mitsuhiko avatar Dec 05 '16 19:12 mitsuhiko

Why not just entirely skip installing the hook if it's not a tty? Is it possible that stdin being a tty could change while the process is running?

mattrobenolt avatar Dec 14 '16 21:12 mattrobenolt

@mattrobenolt i don't know if it can change on the same stream but there are a few cases where this can be an issue:

  • you fork off a child and close the input stream
  • someone patches sys.stdin at runtime

mitsuhiko avatar Dec 14 '16 22:12 mitsuhiko

We've been going nuts with typos on an interactive console causing emails from Sentry, and the delay that sending the message causes when we do hit errors from the console before it shows us the error interactively. We would really appreciate this feature!

ryanhiebert avatar Feb 08 '18 16:02 ryanhiebert