raven-objc icon indicating copy to clipboard operation
raven-objc copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Retain errors if send fails

Open toolboxash opened this issue 10 years ago • 4 comments

Original feature merged from sblepa with tests fixed.

toolboxash avatar Mar 24 '15 13:03 toolboxash

Thanks a lot for pull request. Can I comment changes?

One general comment - default implementation is not saving data for failed request. So every developer should implement same himself.

emartynov avatar Mar 31 '15 07:03 emartynov

Did you need me to do anything?

On 31 Mar 2015, at 08:26, Eugen Martynov [email protected] wrote:

Thanks a lot for pull request. Can I comment changes?

One general comment - default implementation is not saving data for failed request. So every developer should implement same himself.

— Reply to this email directly or view it on GitHub https://github.com/getsentry/raven-objc/pull/52#issuecomment-87973888.

toolboxash avatar Mar 31 '15 07:03 toolboxash

I don't know how Raven people are handling comments for pull request. It is up to you but I would implement changes if you agree with them.

emartynov avatar Mar 31 '15 07:03 emartynov

@emartynov You're free to make a fork of @toolboxash's code, make the changes you'd like, and submit your own pull request. If @toolboxash agrees with your changes, we can merge your pull request and close this one.

asbjornu avatar Mar 31 '15 09:03 asbjornu