raven-objc icon indicating copy to clipboard operation
raven-objc copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Carthage compatibility

Open dodikk opened this issue 10 years ago • 9 comments

Added a static library and iOS8 framework targets. The library is now compatible with Carthage package manager.

Note : you should to make a fork so that carthage versioning would recognise these changes

dodikk avatar Feb 20 '15 10:02 dodikk

The first commit of this PR seems to be covered by https://github.com/getsentry/raven-objc/pull/44, which is merged now. Can you merge with master to update this PR so it can be merged without conflicts?

Thanks for the PR by the way :)

timorzadir avatar Feb 22 '15 12:02 timorzadir

Can you merge with master to update this PR so it can be merged without conflicts?

I'll do it. Probably over the week end.

dodikk avatar Feb 25 '15 09:02 dodikk

Merge done.

dodikk avatar Mar 14 '15 13:03 dodikk

I think, dropping a static library target for a framework is too radical. Dynamic linking has some drawbacks on iOS. https://github.com/Carthage/Carthage/issues/188 Moreover, some of us have to support iOS 7 in legacy projects (dynamic frameworks cannot be used in those).

So, I have preserved a static library target during the merge. Also, I've added a static framework target. I guess, many developers would like to keep linking sentry client statically.

dodikk avatar Mar 14 '15 13:03 dodikk

Great. There is one issue though. After switching to XCTest the test suite will no longer run.

timorzadir avatar Mar 15 '15 11:03 timorzadir

After switching to XCTest the test suite will no longer run.

Not sure what you mean. I have tested XCTest targets and they worked. What else do you want me to fix? Are there any scripts I've missed?

dodikk avatar Mar 16 '15 12:03 dodikk

In your PR it has been added a new Raven group, a content-less RavenClientTests group, a RavenTests group with an empty test, and an extra test bundle in the test navigator. One of the test bundles will not run, but the other one seems to run ok.

It would be awesome if you could clean away the unused groups and the extra test-bundle in the test navigator.

timorzadir avatar Mar 19 '15 22:03 timorzadir

@timorzadir could you please post some screenshots to avoid the misunderstanding again?

dodikk avatar Mar 20 '15 10:03 dodikk

One of the test bundles will not run, but the other one seems to run ok.

Cold you provide more detailed steps to reproduce? Before submitting this patch I have tested both the static lib based tests and the framework based tests. Both of them worked for me. So, I cannot reproduce the issue.

Note : two test bundles cannot be executed within the same scheme due to a bug of Xcode. Isn't it a reason why you can run only one bundle?

dodikk avatar Mar 20 '15 10:03 dodikk