raven-go icon indicating copy to clipboard operation
raven-go copied to clipboard

use the stacktrace of cause, if that doesn't have one, use the one fr…

Open femaref opened this issue 7 years ago • 9 comments

…om err

https://github.com/getsentry/raven-go/pull/215

femaref avatar Oct 29 '18 13:10 femaref

oh, right. I just saw that there is a reference I missed in http.go. I'll add that. Or are you talking about something different?

femaref avatar Nov 01 '18 16:11 femaref

sure, will do.

femaref avatar Nov 02 '18 11:11 femaref

This is a high value change.

Without this change, as far as I can tell, reporting errors via raven.CaptureError at the top of a callstack will lose their original pkgErrors.Wrap stacktrace.

jotto avatar Nov 17 '18 22:11 jotto

yes, that is exactly what is happening.

femaref avatar Nov 18 '18 21:11 femaref

@femaref do you mind pushing your http fix, at least to your repo? I'd like to use your branch instead of creating another one

jotto avatar Nov 18 '18 21:11 jotto

will do once I'm back at my notebook.

femaref avatar Nov 18 '18 21:11 femaref

@jotto actually, it's part of the refactor branch: https://github.com/femaref/raven-go/blob/refactor/transport.go

femaref avatar Nov 18 '18 21:11 femaref

thank you @femaref

is there an intent with the refactor beyond addressing the stacktrace issue?

jotto avatar Nov 18 '18 21:11 jotto

yes, there is a lot of duplicate code between Capture* and Capture*WithWait. I'm reducing that duplication.

femaref avatar Nov 18 '18 23:11 femaref