raven-go
raven-go copied to clipboard
eventID returned even for failed request by `CaptureMessageAndWait`
Error from client.Transport.Send
is not handled, the error returned by following code is assigned to field ch
, but this ain't checked anywhere in caller.
https://github.com/getsentry/raven-go/blob/563b81fc02b75d664e54da31f787c2cc2186780b/client.go#L524-L525
inside caller it is not handled here
https://github.com/getsentry/raven-go/blob/563b81fc02b75d664e54da31f787c2cc2186780b/client.go#L595-L612
nor it's caller
https://github.com/getsentry/raven-go/blob/563b81fc02b75d664e54da31f787c2cc2186780b/client.go#L654-L659
How to reproduce:
In your client code simply give DSN with wrong domain or somehow the sentry service should be inaccessible to your client code and you could reproduce this issue.
Version:
$ docker images | grep sentry
docker.io/sentry 8.22 d4d5c93a8759 2 months ago 536 MB
So frustrating want the ch
seems to contain no errors and still, the SDK is failing somewhere somehow to deliver the msg to sentry.