raven-go
raven-go copied to clipboard
getsentry
84 return errors on capturing failure
Add methods that return error when capturing
The client's capture method returns an error channel that according to the docs is intended to be used for checking if a packet was sent successfully whenever that is important.
The ...AndWait methods use this channel, but only to wait. They do
not capture the possible error coming from that channel.
The changes in this commit suggest to use the error and return it, so that a user may check whether a packet was sent successfully using new top level methods, instead of having to write their own.
The newly introduced methods follow the naming scheme
Capture$SOMETHINGAndConfirm, where the returned error is considered
confirmation.
Work on #84
Any comments / change requests on this, @mattrobenolt? Have you had time to look at it yet?
why is there no reaction? is this repo dead? will you provide the possibility of someone else taking over, as the current developer(s) obviously don't use enough time to maintain the project? @mattrobenolt
don't mean to be cheeky, but getting a bit upset over being ignored...