raven-go icon indicating copy to clipboard operation
raven-go copied to clipboard

Change RecoveryHandler to accept and return http.Handler

Open tdterry opened this issue 9 years ago • 2 comments

This is a PR for the proposal in #78. It makes RecoveryHandler idiomatic by accepting and returning http.Handler like middleware in other popular libraries. The previous functionality is exposed in the new RecoveryHandlerFunc method.


This change is Reviewable

tdterry avatar Sep 13 '16 19:09 tdterry

I just ran into this problem and would like to voice my support for this breaking change.

If API breaks are a concern, maybe it's time to look into gopkg.

jchv avatar Dec 02 '16 15:12 jchv

I'm a huge proponent of having something like this! I wrote a custom wrapper earlier today because I was looking for this. I'd be happy to see NewRecoveryHandler used in order to avoid API breakage.

parkr avatar Nov 27 '17 20:11 parkr