freight icon indicating copy to clipboard operation
freight copied to clipboard

feat(github-apps): Do not fail immediately on missing GitHub contexts

Open tonyo opened this issue 6 years ago • 0 comments

Sometimes GitHub doesn't update commit status contexts in time (e.g. for Travis, or Azure Pipelines), and Freight deploys fail because of that. In particular, it may hurt if we deploy something automatically after a push to master. This change relaxes the check a bit: Freight now retries the github-app check if some contexts are missing on the first check.

Not super happy with this. Inside the check code we don't have access to the deploy identifier, and we also run checks outside the deploy context when we start new builds via the UI. This basically means that we'll still get the "No contexts were present" error in some cases. Open to suggestions on how to improve this.

tonyo avatar Jul 12 '19 16:07 tonyo