craft icon indicating copy to clipboard operation
craft copied to clipboard

Craft fails the release-registry target if version already exists

Open bruno-garcia opened this issue 2 years ago • 3 comments

When we add a new package to release-registry, it's intuition for folks to add the version we're about to release. The one that actually has that package.

Craft can't handle that, and crashes if the version already exists:

image

If the package isn't there, craft also fails. So we're required to add it manually first.

Request: Please ignore when the package already exists and carry on the release.

bruno-garcia avatar Jul 12 '22 16:07 bruno-garcia

@bruno-garcia can you link the run for this? I'm not sure I completely understand all the moving parts here and would like to see where the trace is coming from

asottile-sentry avatar Jul 13 '22 12:07 asottile-sentry

@asottile-sentry I think this is the run that failed: https://github.com/getsentry/publish/runs/7302721278?check_suite_focus=true

We usually manually add new modules to https://github.com/getsentry/sentry-release-registry like here https://github.com/getsentry/sentry-release-registry/pull/78/files . We have to pick a version that we add there.

Let's assume we want to add a new module for 6.3.0, we can't just add it to the release registry as 6.3.0 as the release build will then fail like the one bruno mentioned (linked at the start of my message). So we have to add it to the release registry with an older version that doesn't really exist to make the release work.

adinauer avatar Jul 14 '22 13:07 adinauer

hmmm -- if you create the release manually should you then check the registry box in the publish issue so it skips the (already done) one?

asottile-sentry avatar Jul 14 '22 13:07 asottile-sentry