arroyo icon indicating copy to clipboard operation
arroyo copied to clipboard

fix: message handling in unfold / unbatch

Open mj0nez opened this issue 1 year ago • 3 comments

This PR aligns the Unbatch and Unfold strategies to the behavior of their counterparts Batch and Reduce. Unbatch now just submits the values of a submitted ValuesBatch one after another to the next step. Therefore, the logic was reduced to rely fully on the passed generator function for building a Message's Value.

I tried my best fixing the typing issues but there is still one in arroyo/processing/strategies/batching.py:116 with which I had no luck.

Closes #369

mj0nez avatar May 21 '24 21:05 mj0nez

@mj0nez I haven't looked at the PR in detail yet since your recent changes, do you need help with the types, or what is the status? I can make some room this week to continue it if so

untitaker avatar Jul 08 '24 15:07 untitaker

@mj0nez I haven't looked at the PR in detail yet since your recent changes, do you need help with the types, or what is the status? I can make some room this week to continue it if so

Yeah... it would be great if you could take over.

mj0nez avatar Jul 08 '24 15:07 mj0nez

@untitaker Did you get a chance to look at the PR? :)

mj0nez avatar Aug 07 '24 08:08 mj0nez

discard my earlier comment. this is done now. thanks!

untitaker avatar Sep 26 '24 15:09 untitaker