action-release icon indicating copy to clipboard operation
action-release copied to clipboard

Glob support for `sourcemaps`

Open austince opened this issue 3 years ago • 6 comments

It would be nice not to have to expand this ourselves, eg. just:

with:
  sourcemaps: ui/build/static/js/*.map

This could probably be done with just running the array through minimatch or such.

Originally posted by @amcdnl in https://github.com/getsentry/action-release/issues/43#issuecomment-766800395

austince avatar Nov 28 '22 22:11 austince

Thanks @austince for filing! At the moment, we're not currently investing in the action but we will look at this when we do.

armenzg avatar Nov 30 '22 15:11 armenzg

Nice, thanks @armenzg!

we're not currently investing in the action

Does this apply to any changes, or just writing the feature? We may be able to contribute a PR if you'd have the bandwidth to review, but understand if not.

austince avatar Nov 30 '22 16:11 austince

Nice, thanks @armenzg!

we're not currently investing in the action

Does this apply to any changes, or just writing the feature? We may be able to contribute a PR if you'd have the bandwidth to review, but understand if not.

We welcome PRs! Tag me and I will be able to help.

armenzg avatar Dec 01 '22 17:12 armenzg

We are using

with:
  sourcemaps: ui/build/static/js/

and it uploads all the sourcemaps.

ricardo-dematos avatar Apr 20 '23 12:04 ricardo-dematos