Pascal Getreuer

Results 27 comments of Pascal Getreuer

Thanks @aus10code for reporting this and @drashna for those details. As a quick possible workaround, try bypassing Achordion while the mouse layer is on: ```c uint16_t achordion_timeout(uint16_t tap_hold_keycode) { if...

@sigprof thanks a bunch for this excellent analysis! That dissects what is going on and makes the root cause clear. Achordion recursively calls `process_record()` in a few ways. I believe...

@EdenEast, thank you for the contribution! I just realized that you had in fact signed the CLA. Normally the CLA status on this page will update automatically, however, in this...

@gazpachoking thank you so much for these contributions! I agree on the whole with all the changes you describe. Really appreciated. > The achordion_streak_timeout function was meant to be passed...

Thank you for the continued refinement on this PR! This looks about good to go. > Your understanding of the original is correct. I first changed it to as you...

Congratulations, that's fantastic! Thanks for the message. Please, there's no rush to act on this PR, understood that you are fully occupied in these first few weeks especially. I wish...

This is good to go, thank you for your contribution! Wishing you best of luck and happy times with the baby.

That's helpful, @SavageMessiah! Thanks to your comment, I realize now what has happened. The intention is that Achordion bypasses combos and other non-key events. This is [being checked as](https://github.com/getreuer/qmk-keymap/blob/d1464c4e7c7320a2ca4ece4ef27492b87639a620/features/achordion.c#L115) ```c...

@JanValiska thank you for the detailed bug report! Your explanation and video make the problem very clear. ## Problem In hindsight, I can see why this defect occurs. The sequence...

@JanValiska, I just pushed https://github.com/getreuer/qmk-keymap/commit/744119420424f567bc937075fadd9772867d472e to fix the mods hand-off problem in how eager mods are handled: * When an eager mod `MT` is settled as held, Achordion continues to...