redash icon indicating copy to clipboard operation
redash copied to clipboard

Bump pyodbc from 4.0.28 to 5.1.0

Open ehooi opened this issue 1 year ago • 1 comments

What type of PR is this?

  • [ ] Refactor
  • [ ] Feature
  • [ ] Bug Fix
  • [ ] New Query Runner (Data Source)
  • [ ] New Alert Destination
  • [x] Other

Description

Bump pyodbc from 4.0.28 to 5.1.0 This major version upgrade has NO api changes.

Below is copied from pyodbc release notes.


5.0.0 Release

This is the first 3.x only pyodbc release, supporting Python 3.8-3.12.

The API is backwards compatible, so previous Python 3 products using pyodbc should not need any changes.

Please note that macOS ARM / Apple Silicon binary builds have been problematic due inconsistencies in the way unixODBC libraries can be installed. Please see the issues and discussions.


5.0.1 with fix for Azure tokens / binary attrs_before

This is a bug fix for 5.0.0 that restores the ability to pass bytes objects in the attrs_before parameter when connecting. This is often used for Azure with a token. Issue https://github.com/mkleehammer/pyodbc/issues/1289


5.1.0 with Mac ARM (M1 & M2) binaries

Mac M1 & M2 binaries are available going forward.

GitHub added new Mac ARM action runners which is what we use to build each release.

Thanks to @keitherskine who made all this happen. Not only did he write the original release code for all of the other versions, he jumped on the new Mac runner as soon as it was available.

I'd also like to thank the many people working through the Mac binary confusion, testing and providing work arounds until this runner was available: @Carreau @ndmlny-qs @jordantshaw @gabalafou @v-chojas and many others on the Issue.

If you are a Mac user, please let us know how this works for you.


How is this tested?

  • [x] Unit tests (pytest, jest)
  • [ ] E2E Tests (Cypress)
  • [ ] Manually
  • [ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

ehooi avatar May 11 '24 01:05 ehooi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.83%. Comparing base (1b946b5) to head (0deaa55). Report is 3 commits behind head on master.

:exclamation: Current head 0deaa55 differs from pull request most recent head e61e9e8. Consider uploading reports for the commit e61e9e8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6962   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files         161      161           
  Lines       13094    13094           
  Branches     1814     1814           
=======================================
  Hits         8359     8359           
  Misses       4432     4432           
  Partials      303      303           

codecov[bot] avatar May 11 '24 01:05 codecov[bot]

Cool, this looks useful and seems like it'll upgrade without causing issues.

We can't merge it for a little bit (few days) as we're taking some time to figure out a complicated roll back (details here). But once that's done, this seems like it should slot right in. :smile:

justinclift avatar May 12 '24 23:05 justinclift