redash
redash copied to clipboard
Enable hot reload by default
What type of PR is this?
Enabled hot reload by default
- [x] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] New Query Runner (Data Source)
- [ ] New Alert Destination
- [ ] Other
Description
How is this tested?
- [ ] Unit tests (pytest, jest)
- [ ] E2E Tests (Cypress)
- [ ] Manually
- [ ] N/A
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.76%. Comparing base (
372adfe
) to head (6007a57
). Report is 4 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #6940 +/- ##
=======================================
Coverage 63.76% 63.76%
=======================================
Files 161 161
Lines 13085 13085
Branches 1812 1812
=======================================
Hits 8344 8344
Misses 4438 4438
Partials 303 303
@eradman could you please review?
This did not work for me. After starting with make up
, I did not see the server reload after editing files in redash/...
docker compose logs -f server
@eradman please set SERVER_MOUNT=/app
in your .env file and try again
@eradman modified makefile to add SERVER_MOUNT=/app
to .env
Interesting, the concept of the PR seems useful.
@justinclift could you check PR? almost impossible to get any feedback from @eradman