redash icon indicating copy to clipboard operation
redash copied to clipboard

Enable hot reload by default

Open AndrewChubatiuk opened this issue 9 months ago • 7 comments

What type of PR is this?

Enabled hot reload by default

  • [x] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] New Query Runner (Data Source)
  • [ ] New Alert Destination
  • [ ] Other

Description

How is this tested?

  • [ ] Unit tests (pytest, jest)
  • [ ] E2E Tests (Cypress)
  • [ ] Manually
  • [ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

AndrewChubatiuk avatar May 01 '24 14:05 AndrewChubatiuk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.76%. Comparing base (372adfe) to head (6007a57). Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6940   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         161      161           
  Lines       13085    13085           
  Branches     1812     1812           
=======================================
  Hits         8344     8344           
  Misses       4438     4438           
  Partials      303      303           

codecov[bot] avatar May 01 '24 14:05 codecov[bot]

@eradman could you please review?

AndrewChubatiuk avatar May 03 '24 09:05 AndrewChubatiuk

This did not work for me. After starting with make up, I did not see the server reload after editing files in redash/...

docker compose logs -f server

eradman avatar May 03 '24 16:05 eradman

@eradman please set SERVER_MOUNT=/app in your .env file and try again

AndrewChubatiuk avatar May 03 '24 16:05 AndrewChubatiuk

@eradman modified makefile to add SERVER_MOUNT=/app to .env

AndrewChubatiuk avatar May 03 '24 17:05 AndrewChubatiuk

Interesting, the concept of the PR seems useful.

justinclift avatar May 05 '24 18:05 justinclift

@justinclift could you check PR? almost impossible to get any feedback from @eradman

AndrewChubatiuk avatar May 05 '24 18:05 AndrewChubatiuk