moved cypress out of container

[AndrewChubatiuk]

What type of PR is this?

• [x] Refactor

Description

Moving cypress out of container decreases e2e test run up to 5 minutes, also for local setup no need to build container and install same deps. Also cypress builds from the start once there were changes in viz-lib, which it actually doesn't rely on.

• replaced seed-data command with before hooks in cypress
• moved cypress out of container
• replaced viz-lib linking with just a link

How is this tested?

• [ ] Unit tests (pytest, jest)
• [ ] E2E Tests (Cypress)
• [ ] Manually
• [ ] N/A

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.76%. Comparing base (372adfe) to head (93d5497). Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6931   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         161      161           
  Lines       13085    13085           
  Branches     1812     1812           
=======================================
  Hits         8344     8344           
  Misses       4438     4438           
  Partials      303      303           

[AndrewChubatiuk]

@justinclift @eradman could you please review?

[justinclift]

@AndrewChubatiuk I can't do it tonight (end of day for me already), and I probably can't do it tomorrow either (paperwork day). Can look at it after that though, if no-one has gotten to it. :smile:

One question though, as it's not obvious from the PR description, but what's the benefit from moving Cypress out of a container?

I can understand upgrading old Cypress version to newer, that's a good thing. :smile:

I'm just unsure what the purpose/benefit/etc of removing the container bit is? Note, that's not me arguing, I'm actually asking. :smile:

[AndrewChubatiuk]

Moving cypress out of container decreases e2e test run up to 5 minutes, also for local setup no need to build container and install same deps. Also cypress builds from the start once there were changes in viz-lib, which it actually doesn't rely on

[justinclift]

decreases e2e test run up to 5 minutes

Awesome, that sounds like a good improvement. :smile: