redash
redash copied to clipboard
upgraded cypress 11.x -> 13.x
What type of PR is this?
-
upgraded cypress to fix this issue
-
updated db seed function which helped to remove not needed request-cookie package
-
removed unneeded cypress dockerfile to speed up CI build (temporary added image to pass CI checks)
-
updated dockerignore with more unused content for redash image
-
removed compose profiles
-
[x] Refactor
-
[ ] Feature
-
[x] Bug Fix
-
[ ] New Query Runner (Data Source)
-
[ ] New Alert Destination
-
[ ] Other
Description
How is this tested?
- [ ] Unit tests (pytest, jest)
- [x] E2E Tests (Cypress)
- [x] Manually
- [ ] N/A
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
@justinclift could you please review when have time?
I don't understand this part very well. Come and take a look. @justinclift 😁
@gaecoli All good, I'll take a look at this in a few hours. :smile:
@gaecoli All good, I'll take a look at this in a few hours. 😄
@justinclift please merge this PR before other ones in a repo to speed up e2e tests execution for other pipelines
please merge this PR before other ones in a repo to speed up e2e tests execution for other pipelines
Sorry, just saw that. I don't have time to look at this properly for a few more hours though, so it'll have to wait until then.
Sorry @AndrewChubatiuk, this will have to be a tomorrow thing instead of today. I've run out of time and mental energy for today. :facepalm:
Unless someone else gets to it overnight of course. :smile:
@justinclift do you have time for it today?
Yeah. I just finished most of the other bits I need to take care of today, so I'll grab some food now then go through this. :smile:
@AndrewChubatiuk This mostly looks good. I've asked @eradman to take a look at the most complex JS file (cypress.js) in there, as it's more complex than what I can currently grok.
removed compose profiles
Will that affect people who run the Cypress tests manually themselves? ie from the cli, prior to making a PR
@justinclift updated makefile, so it should not affect existing user's setup
From my perspective this change is too large. We need to break this update into smaller steps so that we are able to fully understand.
i can help if you have any questions. most of the changes are happening in yarn.lock, cause lot's of old packages were removed after percy upgrade
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.76%. Comparing base (
af0773c
) to head (9d8e7d2
). Report is 35 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #6912 +/- ##
==========================================
- Coverage 63.82% 63.76% -0.06%
==========================================
Files 161 161
Lines 13060 13066 +6
Branches 1803 1803
==========================================
- Hits 8335 8332 -3
- Misses 4425 4431 +6
- Partials 300 303 +3
@eradman @justinclift here's a smaller PR https://github.com/getredash/redash/pull/6931/files