redash icon indicating copy to clipboard operation
redash copied to clipboard

Feature: Update the Query Owner

Open jredblue opened this issue 1 year ago • 3 comments

What type of PR is this?

  • [ ] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] New Query Runner (Data Source)
  • [ ] New Alert Destination
  • [ ] Other

Description

How is this tested?

  • [ ] Unit tests (pytest, jest)
  • [ ] E2E Tests (Cypress)
  • [x] Manually
  • [ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Shows the process for updating the owner of a query. The previous owner will get added to the editor permission list after the update is complete.

https://github.com/getredash/redash/assets/30450773/7dc1cb4d-31bb-4be0-985c-e49002815b24

Shows the permissions restriction that requires the new query owner to have access to the query's data source.

https://github.com/getredash/redash/assets/30450773/97770007-3d44-4261-9bea-1e97316e96b1

jredblue avatar Mar 06 '24 16:03 jredblue

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 63.37%. Comparing base (34723e2) to head (444bfd1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6801      +/-   ##
==========================================
- Coverage   63.43%   63.37%   -0.06%     
==========================================
  Files         163      163              
  Lines       13200    13213      +13     
  Branches     1822     1825       +3     
==========================================
+ Hits         8373     8374       +1     
- Misses       4530     4540      +10     
- Partials      297      299       +2     
Files Coverage Δ
redash/handlers/queries.py 81.00% <7.69%> (-5.10%) :arrow_down:

codecov[bot] avatar Mar 06 '24 16:03 codecov[bot]

Hmmm, the frontend lint test is failing. @jredblue Are you ok to investigate that and fix whatever is wrong with it?

The wiki docs might be useful, depending on how you've setup your development environment:

  • https://github.com/getredash/redash/wiki/Local-development-setup
  • https://github.com/getredash/redash/wiki/Testing-your-changes

:smile:

justinclift avatar Mar 30 '24 00:03 justinclift

Hey guys thanks for getting back to me! I’ll start working on the backend logic and frontend tests, as well as investigating the lint failures. I’ll provide an update after that, appreciate the info!

jredblue avatar Apr 01 '24 18:04 jredblue