redash icon indicating copy to clipboard operation
redash copied to clipboard

Published 20 hours ago • verified publisher icon getredash

Node 18

Open AndrewChubatiuk opened this issue 1 year ago • 2 comments

What type of PR is this?

Node 18 is not the latest stable, but at least still maintained in contrast to 16 and 14. Tested it with Node 20 as well, but currently there's no cypress image with node 20

  • [x] Refactor
  • [ ] Feature
  • [ ] Bug Fix
  • [ ] New Query Runner (Data Source)
  • [ ] New Alert Destination
  • [ ] Other

Description

How is this tested?

  • [ ] Unit tests (pytest, jest)
  • [ ] E2E Tests (Cypress)
  • [ ] Manually
  • [ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

AndrewChubatiuk avatar Feb 07 '24 10:02 AndrewChubatiuk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.42%. Comparing base (52cd6ff) to head (568407c).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6752   +/-   ##
=======================================
  Coverage   63.42%   63.42%           
=======================================
  Files         162      162           
  Lines       13173    13173           
  Branches     1819     1819           
=======================================
  Hits         8355     8355           
  Misses       4522     4522           
  Partials      296      296

codecov[bot] avatar Feb 07 '24 10:02 codecov[bot]

@justinclift @guidopetri could you please review it?

AndrewChubatiuk avatar Feb 10 '24 07:02 AndrewChubatiuk

@justinclift @guidopetri are you still maintaining a repo?

AndrewChubatiuk avatar Feb 21 '24 09:02 AndrewChubatiuk

@AndrewChubatiuk I'm taking some time off after hitting the early stages of burn out. :frowning:

justinclift avatar Feb 22 '24 20:02 justinclift

Thanks for getting this done @AndrewChubatiuk. I'm going to be less active on GitHub for maybe a week or so, but feel free to ping me if something needs attention. :smile:

justinclift avatar Feb 22 '24 22:02 justinclift

@justinclift wanted to merge #6674. MR is failing, but this is because it's running scenarios from master

AndrewChubatiuk avatar Feb 22 '24 23:02 AndrewChubatiuk

@AndrewChubatiuk Interesting. That looks like it'll need some proper thinking about to fix, which I don't have the mental bandwidth for at the moment. :frowning:

Saying that because I'm under the impression it shouldn't be running scenarios from master when the PR is in a different branch.

If that's what's really happening, then that sounds like a problem in itself. :frowning:

justinclift avatar Feb 23 '24 00:02 justinclift

@AndrewChubatiuk can you update https://github.com/getredash/redash/wiki/Local-development-setup to match? I assume this change implies that we should be running nvm use 18 for development now.

eradman avatar Feb 27 '24 01:02 eradman

I have made an UPDATE to the wiki. https://github.com/getredash/redash/wiki/Local-development-setup/_compare/a534424f2d8da9221e29019ed12bef94c6d4ed2f...c5c70019e6e0ae773b9a35f6d5a722ccde710616

snickerjp avatar Feb 27 '24 17:02 snickerjp

Awesome. Thanks heaps @snickerjp. :smile:

justinclift avatar Mar 01 '24 21:03 justinclift