UI switched with a checkbox called Use Custom for Oracle

[radkmb]

What type of PR is this?

• [x] Refactor
• [x] Feature

Description

Related to #6332 . This change to the PR changed the UI so that the "Use Custom" checkbox switches the UI instead of the user having to type in a specific string to switch functions.

How is this tested?

• [x] Unit tests (pytest, jest)
• [ ] E2E Tests (Cypress)
• [x] Manually
• [ ] N/A

Related Tickets & Documents

• #6332

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

https://github.com/getredash/redash/assets/8194473/af50a4e2-ca76-436b-a0cb-d23a2b1ca1f0

[justinclift]

@snickerjp This PR will probably be of interest to you. :smile:

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c47bef) 63.38% compared to head (3ada201) 63.38%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6696   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         162      162           
  Lines       13165    13165           
  Branches     1817     1817           
=======================================
  Hits         8344     8344           
  Misses       4532     4532           
  Partials      289      289           

[justinclift]

@snickerjp Actually, would you be interested in reviewing this PR, and also seeing if the concept itself looks good? :smile:

[snickerjp]

Looks like a very good concept. I too would have liked to make this change.

[justinclift]

@snickerjp Ok, so should we merge this as-is? :smile:

[snickerjp]

@justinclift Can I see some more? I still don't understand the part where you pass values from Front UI to query_runner/oracle.py.

Maybe some changes are needed on the query_runner/oracle.py side.

[justinclift]

@snickerjp The full source code for this PR is here:

https://github.com/radkmb/redash/tree/toggle-custom-ui

It looks like the current Redash master branch, with 3 new commits added on top:

https://github.com/radkmb/redash/commits/toggle-custom-ui/

You'll probably need to ask @radkmb about the changes, as I didn't write this code. :smile:

[justinclift]

@radkmb Hopefully you're ok to assist @snickerjp with this? :smile:

[snickerjp]

@justinclift Thank you very much.

I will look into the part that works with query_runner/oracle.py.

[radkmb]

@justinclift Thanks for the confirmation! I will also review the part that works with query_runner/oracle.py.

[snickerjp]

With this source code, it doesn't seem to work without modifications

git checkout -b radkmb-toggle-custom-ui
git pull https://github.com/radkmb/redash.git toggle-custom-ui
yarn
make build
make compose_build
make up

The browser (or proxy) sent a request that this server could not understand.

[justinclift]

With this source code, it doesn't seem to work without modifications

Ahhh. Thanks for checking @snickerjp.

@radkmb Are you ok to look into the above error and fix things? :smile:

[sk-on]

Why do I not have the option to connect to oracle Database

[justinclift]

@sk-on Which version of Redash are you using? :smile: