redash icon indicating copy to clipboard operation
redash copied to clipboard

filter widget results to fix tests during repeatable execution

Open AndrewChubatiuk opened this issue 1 year ago • 2 comments

What type of PR is this?

fixed one of tests, which fails, when running cypress tests without db recreation

  • [ ] Refactor
  • [ ] Feature
  • [x] Bug Fix
  • [ ] New Query Runner (Data Source)
  • [ ] New Alert Destination
  • [ ] Other

AndrewChubatiuk avatar Jan 04 '24 12:01 AndrewChubatiuk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.82%. Comparing base (af0773c) to head (3a34eb9). Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6693   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         161      161           
  Lines       13060    13060           
  Branches     1803     1803           
=======================================
  Hits         8335     8335           
  Misses       4425     4425           
  Partials      300      300           

codecov[bot] avatar Jan 04 '24 19:01 codecov[bot]

@justinclift could you please review this MR?

AndrewChubatiuk avatar Jan 11 '24 23:01 AndrewChubatiuk

Hmmm, looks like you're still working on this. Um, ping me when you're happy with it? :smile:

justinclift avatar Apr 10 '24 12:04 justinclift

just rebased it, it's ready to be merged

AndrewChubatiuk avatar Apr 10 '24 13:04 AndrewChubatiuk