redash
redash copied to clipboard
Rockset Query Runner: Fetch collections when api key is access limited
When the rockset api key does not have full access to all workspaces the collection fetching fails. This PR checks for a result when fetching collection columns.
What type of PR is this?
- [X] Bug Fix
Description
When the rockset api key does not have full access to all workspaces the collection fetching fails. This PR checks for a result when fetching collection columns.
Expected compatibility: Rockset production db.
How is this tested?
- [X] Manually
- Build image
- Set up connection
- Test connection
- Go to schema overview in /queries/new
Refresh works although our API key does not have read access to all collections (across workspaces)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Codecov Report
Merging #6661 (9c67460) into master (9bbdb4b) will increase coverage by
0.18%. Report is 1 commits behind head on master. The diff coverage is90.24%.
Additional details and impacted files
@@ Coverage Diff @@
## master #6661 +/- ##
==========================================
+ Coverage 62.57% 62.75% +0.18%
==========================================
Files 161 162 +1
Lines 13184 13264 +80
Branches 1797 1807 +10
==========================================
+ Hits 8250 8324 +74
- Misses 4649 4654 +5
- Partials 285 286 +1
| Files | Coverage Δ | |
|---|---|---|
| redash/query_runner/influx_db_v2.py | 96.10% <96.10%> (ø) |
|
| redash/query_runner/rockset.py | 29.48% <0.00%> (-1.18%) |
:arrow_down: |
@guidopetri Sorry just saw this. We ended up going with BigQuery and shut down our Rockset instances, so.I don't really have the means to develop this further unfortunately.
I don't really have the means to develop this further unfortunately.
No worries. Lets close this PR for now.
Maybe future people using Rockset will be able to build on it anyway. :smile: