Fix columns duplication on MongoDB Query Runner #6640

[masayuki038]

What type of PR is this?

• [x] Bug Fix

Description

Bug fix for https://github.com/getredash/redash/issues/6640. And added some tests for MongoDB Query Runner.

How is this tested?

• [x] Unit tests (pytest, jest)
• [ ] E2E Tests (Cypress)
• [x] Manually
• [ ] N/A

Related Tickets & Documents

Closes #6640

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

without fields

with fields

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (939bec2) 63.42% compared to head (8ea665e) 63.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6641      +/-   ##
==========================================
+ Coverage   63.42%   63.72%   +0.29%     
==========================================
  Files         162      162              
  Lines       13173    13174       +1     
  Branches     1819     1820       +1     
==========================================
+ Hits         8355     8395      +40     
+ Misses       4522     4473      -49     
- Partials      296      306      +10     

Files	Coverage Δ
redash/query_runner/mongodb.py	60.09% <100.00%> (+19.03%)	:arrow_up:

[masayuki038]

@guidopetri @konnectr Thanks for your review.

It looks like two of the tests aren't passing for it? Could you take a look and investigate why?

Sure. I missed something. I'll check it later. Please give me a little time.

[masayuki038]

e2e test still failed. I don't know main branch status... I will re-run it after https://github.com/getredash/redash/pull/6748 is fixed.

[masayuki038]

e2e test passed by merging main branch. @guidopetri Could you check this if you have some time? Thank you always.

[MrSpark2591]

We are having a similar issue right now. Can you guys let me know if I can help in anyways?

[jagal17]

Hi, any news about this? I have also the same problem all the columns of my table are duplicated since I upgraded to the last preview version.

[jagal17]

@clearnote01 @guidopetri any news about this merge? Please we need it!

[masayuki038]

@justinclift It looks like that @guidopetri is busy... I fixed some tests. Could you review this or assign a new reviewer? @jagal17 seems to need this update. Thanks always.

[masayuki038]

Sorry, something is wrong. I will check it. Please wait.

[masayuki038]

I fixed the merge issue. All checks have passed.

@justinclift It looks like that @guidopetri is busy... I fixed some tests. Could you review this or assign a new reviewer?

[justinclift]

@wlach Do you have time/interest to look over this one? :smile:

[justinclift]

@eradman Do you have time to look over this one? It seems a bit more urgent than some of the other PRs around, as people are emailing me directly about this one to ask. :wink:

[eradman]

@eradman Do you have time to look over this one? It seems a bit more urgent than some of the other PRs around, as people are emailing me directly about this one to ask. 😉

I don't have enough knowledge about MongoDB to provide useful input on this. Perhaps merge it and ask for feedback?

[justinclift]

Good idea, lets do that. :smile:

[justinclift]

@masayuki038 Thanks for taking the time to get this over the line. :smile:

[masayuki038]

@justinclift @eradman Thanks for your reviews! I checked it on local, but let me know if someone reported some issues around this. I am checking github every day 😄 Thank you.

[justinclift]

Will do @masayuki038. :smile:

[jagal17]

@justinclift @masayuki038 it is working very well now! thank you very much guys!