redash
redash copied to clipboard
getredash
show column comments by default for athena and postgres if they are defined
What type of PR is this?
- [x] Feature
Description
Use for PostgreSQL and Athena column comments to be shown instead of column name, when it's defined
How is this tested?
Running it on our Redash fork in production for a long time
@AndrewChubatiuk thanks for the PR. Do you have any screenshots handy to show before/after this change?
Codecov Report
Attention: Patch coverage is 54.54545% with 10 lines in your changes are missing coverage. Please review.
Project coverage is 63.79%. Comparing base (
af0773c) to head (aaf81fd). Report is 14 commits behind head on master.
:exclamation: Current head aaf81fd differs from pull request most recent head 30abe0e. Consider uploading reports for the commit 30abe0e to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #6582 +/- ##
==========================================
- Coverage 63.82% 63.79% -0.03%
==========================================
Files 161 161
Lines 13060 13077 +17
Branches 1803 1807 +4
==========================================
+ Hits 8335 8343 +8
- Misses 4425 4430 +5
- Partials 300 304 +4
| Files | Coverage Δ | |
|---|---|---|
| redash/models/__init__.py | 91.95% <ø> (ø) |
|
| redash/query_runner/pg.py | 42.13% <0.00%> (-0.44%) |
:arrow_down: |
| redash/query_runner/athena.py | 51.49% <60.00%> (+0.23%) |
:arrow_up: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gaecoli @junnplus Would either of you have time and interest to review this one? :smile:
@justinclift had to rebase it due to concurrent PR that was merged faster
Hopefully the CI on master doesn't try running the Percy check, now that I've removed the PERCY_TOKEN secret.
Yep, looks like that worked. CI on master is now reporting pass/fail correctly. :smile:
@AndrewChubatiuk Thinking over this PR, it looks like it'll be useful for people. Well done. :smile:
@justinclift, @gaecoli: features and improvements should not be merged until we have a working build and tests (See https://github.com/getredash/redash/pull/6876)
