redash
redash copied to clipboard
Single word title for Google Spreadsheet
What type of PR is this?
- [ ] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] New Query Runner (Data Source)
- [ ] New Alert Destination
- [ ] Other
Description
This fixes and works on the issue #6409 The query_runner for google spreadsheet has now some refactoring and recognise single word title without quotes
How is this tested?
- [ ] Unit tests (pytest, jest)
- [ ] E2E Tests (Cypress)
- [ ] Manually
- [ ] N/A
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Looks like this PR has a formatting problem that needs fixing:
Run ruff check . redash/query_runner/google_spreadsheets.py:122:1: W293 [*] Blank line contains whitespace
I have used a delimiter to have string and title both as a string and still be able to differentiate between them
I guess this might require changing the unit tests as well
@immortalcodes hey, just checking in. Any interest in finishing this PR still?
@immortalcodes hey, just checking in. Any interest in finishing this PR still?
Yup, was busy with some work