redash icon indicating copy to clipboard operation
redash copied to clipboard

Published 20 hours ago • verified publisher icon getredash

Google Spreadsheets worksheet by title cleanup/refactor

Open guidopetri opened this issue 1 year ago • 5 comments

In #5334 , I left a few comments about future work on the "fetch worksheet by title" functionality for the google spreadsheets query runner. We should address those, namely:

  • don't use mixed-type variables
  • allow for non-quoted worksheet titles (single word)
  • verify 0/1 indexing of worksheet numbers, and add comment if it differs

guidopetri avatar Aug 31 '23 12:08 guidopetri

can I work on this issue?

TanyaKansal avatar Oct 05 '23 16:10 TanyaKansal

@TanyaKansal absolutely! Feel free to submit a PR and tag me in it when it's ready for review :)

guidopetri avatar Oct 05 '23 22:10 guidopetri

@guidopetri I didn't quite understand the 3rd point , btw for other 2 please have a look https://github.com/getredash/redash/compare/master...immortalcodes:redash:google-sheet-singleword-title

immortalcodes avatar Oct 08 '23 07:10 immortalcodes

Note - removed duplicated comment above. :wink:

justinclift avatar Oct 16 '23 01:10 justinclift