redash
redash copied to clipboard
Fix git references for Cypress on CI
What type of PR is this?
- [ ] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] New Query Runner (Data Source)
- [ ] New Alert Destination
- [ ] Other
Description
Initially just testing, currently Cypress references are not going right from Github actions to Cypress Dashboard:
How is this tested?
- [ ] Unit tests (pytest, jest)
- [ ] E2E Tests (Cypress)
- [ ] Manually
- [ ] N/A
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Ahhhh. Is this the thing you mentioned the other day, where it would be good to have a clickable link somewhere in the GitHub Actions output that takes people to the Cypress Cloud output for that run? :smile:
Ahhhh. Is this the thing you mentioned the other day, where it would be good to have a clickable link somewhere in the GitHub Actions output that takes people to the Cypress Cloud output for that run? 😄
Yup, as soon as I fix it, Cypress Cloud will be back adding a "Check" to the PRs, which will mirror frontend-e2e-tests
. I already found the issue, now I just need to pass the right variables :)
Awesome. :smile:
@gabrieldutra Looking at the screenshot above, is that a before or after screenshot?
I'm not sure what I'm looking at there, and am uncertain how to check the change/result of this PR after GitHub Actions runs.
@justinclift that's before migrating to GitHub actions. I still need to finish this PR (thus left it as Draft).
Pushed already last weekend, because I wanted to confirm that's what was missing
Cool, no worries. :smile:
@gabrieldutra hey, any plans for finishing this PR?