redash icon indicating copy to clipboard operation
redash copied to clipboard

A less rugged install & set up

Open daddydrac opened this issue 3 years ago • 5 comments

Would make things easier and it's not that big of an ask.

daddydrac avatar May 21 '21 14:05 daddydrac

I'm not sure what the issue is.

The guides are linked in the readme file. Putting them inline feels wrong as it needlessly makes it long and hard to read.

arikfr avatar May 21 '21 14:05 arikfr

I didn’t see that. I had to Google the docker instructions.

I might consolidate commands in docker so you won’t have to do npm, dockerfile and compose separately.

Simply run: docker-compose up --build -d and it will work. I’ll do a PR to automate the install/spin up into one line of code.

daddydrac avatar May 21 '21 14:05 daddydrac

No offense, but you have the anti pattern of docker going on here. I’ll fix this and do a PR; The point of docker is to run 1-2 docker commands and the whole thing works. NPM & any other dependencies should be an after thought, and need not be ran as separate steps in setting up. I also shouldn't have to set up a database either, this can all be done in docker for seamless set up and adoption.

daddydrac avatar May 21 '21 15:05 daddydrac

You're welcome to suggest edits to the readme to make the instructions more discoverable.

As for the split between npm and docker-compose: running npm within Docker for development is painfully slow.

If you're looking for just run Redash for usage vs. development, you can use a setup similar to this, which doesn't require anything but Docker Compose.

arikfr avatar May 21 '21 18:05 arikfr

You're welcome to suggest edits to the readme to make the instructions more discoverable.

As for the split between npm and docker-compose: running npm within Docker for development is painfully slow.

If you're looking for just run Redash for usage vs. development, you can use a setup similar to this, which doesn't require anything but Docker Compose.

The repo you mentioned is IMO also a part of the anti-pattern, since it wasn't updated in over 2 years (references redash v8 and compose file still uses v2 syntax). Moreover, using setup.sh as the official way to deploy a production-ready dockerized application in 2022 is mildly horrifying.

In short, could you please include some way to quickly setup a basic demo instance without additional tinkering and side-effects? i.e. docker-compose.yml with all necessary variables inside, current image, and no external dependencies (such as hardcoded /opt/ paths). Thank you

ondrejmo avatar Jan 27 '22 22:01 ondrejmo