redash
redash copied to clipboard
Update Azure Data Explorer query runner to latest version, add managed identity
What type of PR is this? (check all applicable)
- [x] Refactor
Description
Hello. Here's the list of things that were improved:
- upgraded Azure Data Explorer(Kusto) library to the latest version
- added Materialized Views to schema viewer
- added Managed Identities support for secrets-less auth
- added query user annotation in request description
- added data_scanned
- added simple test to get_schema
@arikfr sure. Should it be two files or just one? how do I avoid duplicating logic?
@spacentropy , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI?
We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.
Hello! Yes, I will prepare everything this week.
@spacentropy This might be useful:
https://github.com/getredash/redash/wiki/Local-development-setup
@spacentropy no worries, take your time. We just wanted to make sure this wasn't an abandoned PR - if it takes a month for you to get around to it it's also fine :)
Codecov Report
Attention: Patch coverage is 11.76471% with 15 lines in your changes are missing coverage. Please review.
Project coverage is 63.76%. Comparing base (
af0773c) to head (674ffa7). Report is 42 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5495 +/- ##
==========================================
- Coverage 63.82% 63.76% -0.06%
==========================================
Files 161 161
Lines 13060 13085 +25
Branches 1803 1810 +7
==========================================
+ Hits 8335 8344 +9
- Misses 4425 4437 +12
- Partials 300 304 +4
| Files | Coverage Δ | |
|---|---|---|
| redash/query_runner/azure_kusto.py | 35.13% <11.76%> (-3.11%) |
:arrow_down: |