redash icon indicating copy to clipboard operation
redash copied to clipboard

RedshiftIAM object missing ssl_config variable

Open peterxichen opened this issue 3 years ago • 4 comments

Issue Summary

"RedshiftIAM object does not contain ssl_config" error when attempting to establish connection to Redshift using IAM role.

Steps to Reproduce

  1. Create new data source Redshift (with IAM User/Role)
  2. Click "Test Connection" will result in error
  3. Resolved after adding self.ssl_config = {} in _get_connection function in our forked code

Unclear if deliberate design decision to leave out ssl_config variable in RedshiftIAM class, however the following solution unblocked our Redash instance. Adding self.ssl_config = {} to L483 like below: https://github.com/getredash/redash/blob/master/redash/query_runner/pg.py#L304

Technical details:

  • Redash Version: v9 beta
  • Browser/OS: Chrome/MacOS
  • How did you install Redash: ECS Fargate + RDS Postgres + Elasticache Redis

peterxichen avatar Apr 08 '21 21:04 peterxichen

This is also happening on Version: 10.0.0 (9c928bd1)

azamrik avatar Dec 29 '21 06:12 azamrik

seems to be happening on Version: 10.1.0 (2589bef1)

epankala avatar Jul 14 '22 20:07 epankala

Thanks for pinging this! I'll open a PR to merge this change into master. I don't believe this omission was a deliberate.

susodapop avatar Jul 14 '22 20:07 susodapop

Not sure if the fix mentioned above is the correct one, but it seems that it worked for us as well.

epankala avatar Jul 15 '22 08:07 epankala

The PR for this (#5465) has been merged, so will be in the next release. :smile:

justinclift avatar Aug 21 '23 03:08 justinclift