redash icon indicating copy to clipboard operation
redash copied to clipboard

Widget level filters doesn't hide when "Use Dashboard Level Filters" selected

Open yoavbls opened this issue 3 years ago • 5 comments

Issue Summary

The option to use dashboard level filters also leaves the filters in the widgets too. Its not a real bug but this behavior is laden and annoying, the duplication of the filters tend to be very verbose. I made a PR and we discussed it a year ago and an half but the PR closed in one of the PR cleans. https://github.com/getredash/redash/pull/3760

What do you think about it? Should I made a new PR with hidden widget filters when "Use Dashboard Level Filters" is selected?

image

Steps to Reproduce

  1. Create query with column filter
  2. Add this query to dashboard
  3. In the dashboard select Select "Use Dashboard Level Filters"

Technical details:

  • Redash Version: Any
  • Browser/OS: Any
  • How did you install Redash: docker-compose

yoavbls avatar Dec 19 '20 02:12 yoavbls

Yes we would welcome reopening this PR 👍

susodapop avatar Feb 08 '22 17:02 susodapop

What is the current priority on this feature request?

lellis2 avatar Oct 14 '22 16:10 lellis2

Nobody is working on this at present. There was a pull request implementing a fix but it was closed. We are happy to reopen this PR if someone would like to test it against the current version of Redash.

susodapop avatar Oct 14 '22 16:10 susodapop

Hi @susodapop ,

When you say "if someone would like to test it against the current version of Redash" what are you implying exactly? More specifically who's the one doing the testing here and how?

lellis2 avatar Oct 14 '22 16:10 lellis2

Sorry for being unclear. The previous pull request is two years old. Testing, in this case, means rebasing its changes on master and verifying that it still works. We wouldn't want to blindly reopen that pull request and merge it since the rest of the code may have changed since it was first written.

susodapop avatar Oct 14 '22 16:10 susodapop