Heatmap controls

[deecay]

What type of PR is this? (check all applicable)

• [x] Feature

Description

Adding more control to heatmap. Brick spacingand zRange (zmin and zmax).

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[rafawendel]

Nice features! I'll wait your considerations on the previous comment and then merge. If you're interested, take a look at this, could be a cool addition!

[guidopetri]

@deecay , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

[justinclift]

Looking over this PR, it seems like the files it was created for are now using TypeScript (eg GeneralSettings.jsx → GeneralSettings.tsx), so will require some rework to match.

It doesn't look too complicated though, at least for someone already familiar with TypeScript (not me at this stage). :smile:

[codecov[bot]]

Codecov Report

Merging #5263 (5b0ba9c) into master (de84c40) will increase coverage by 0.01%. Report is 1 commits behind head on master. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5263      +/-   ##
==========================================
+ Coverage   61.89%   61.90%   +0.01%     
==========================================
  Files         158      158              
  Lines       12966    12966              
  Branches     1773     1773              
==========================================
+ Hits         8025     8027       +2     
+ Misses       4666     4664       -2     
  Partials      275      275              

see 1 file with indirect coverage changes

[justinclift]

@deecay Looks like you're getting this one ready. Is it at the stage now that someone (@eradman maybe?) should review it?

[deecay]

@justinclift yes, it should be ready now.

[eradman]

I think this is good to go