pelican icon indicating copy to clipboard operation
pelican copied to clipboard

no sanity check for PAGINATED_TEMPLATES

Open galaxy4public opened this issue 4 years ago • 3 comments

I think this is an oversight when PAGINATED_DIRECT_TEMPLATES was deprecated in favour of PAGINATED_TEMPLATES. The settings.py file has a sanity check:

https://github.com/getpelican/pelican/blob/master/pelican/settings.py#L633

but for some reason it checks the deprecated option only.

I would expect either both options to be checked there or just the new one.

galaxy4public avatar May 21 '20 12:05 galaxy4public

New setting doesn't fit into that warning (PAGINATED_TEMPLATES is a dict), but yes it can be removed from the check. Deprecation handling code will remove it from settings before that check.

avaris avatar May 21 '20 13:05 avaris

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

stale[bot] avatar Jul 20 '20 13:07 stale[bot]

@galaxy4public / @avaris: In the interest of clarity, what exactly do you think is the best way to proceed here?

justinmayer avatar Jul 23 '20 20:07 justinmayer